[riot-notifications] [RIOT-OS/RIOT] boards/serpente: add serpente board (#13654)

Francisco notifications at github.com
Tue May 19 17:04:46 CEST 2020


@fjmolinas commented on this pull request.

Looks, good some nitpicks below.

Also when I generated the docs the image for the board is way to big, not sure how to re-size images in doxygen.

>  #else
 #include "thread.h"
 #endif
+#include "timex.h"

Why was this change needed?

> +#define LED2_OFF            (LED_PORT.OUTSET.reg = LED2_MASK)
+#define LED2_ON             (LED_PORT.OUTCLR.reg = LED2_MASK)
+#define LED2_TOGGLE         (LED_PORT.OUTTGL.reg = LED2_MASK)
+/** @} */
+
+/**
+ * @name Serpente NOR flash hardware configuration
+ * @{
+ */
+#define SERPENTE_NOR_PAGE_SIZE          (256)
+#define SERPENTE_NOR_PAGES_PER_SECTOR   (16)
+#define SERPENTE_NOR_SECTOR_COUNT       (4096)
+#define SERPENTE_NOR_FLAGS              (SPI_NOR_F_SECT_4K | SPI_NOR_F_SECT_32K)
+#define SERPENTE_NOR_SPI_DEV            SPI_DEV(0)
+#define SERPENTE_NOR_SPI_CLK            SPI_CLK_10MHZ
+#define SERPENTE_NOR_SPI_CS             GPIO_PIN(0, 15)

```suggestion
#define SERPENTE_NOR_SPI_CS             GPIO_PIN(PA, 15)
```

> +PORT_LINUX ?= /dev/ttyACM0
+PORT_DARWIN ?= $(firstword $(sort $(wildcard /dev/tty.usbmodem*)))

These match the defaults in `$(RIOTMAKE)/tools/serial.inc.mk` right? maybe remove?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13654#pullrequestreview-414530479
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200519/6adcfeff/attachment.htm>


More information about the notifications mailing list