[riot-notifications] [RIOT-OS/RIOT] drivers/mtd_spi_nor: derive capacity from JEDEC ID (#14084)

benpicco notifications at github.com
Tue May 19 17:55:50 CEST 2020


@benpicco commented on this pull request.



> +    if ((id->manuf == SPI_NOR_JEDEC_ADESTO) &&
+        (id->device[0] & 0xE0) == 0x80) {

btw I think we can drop the family check: I picked a [random Adesto flash](https://www.mouser.de/datasheet/2/590/DS-AT25PE16_143-1149783.pdf) and that also uses the same size coding.

The GigaDevices Flash on the Serpente board uses the more common Device ID2 encoding. 

(Which also revealed an error in my previous patch: It encodes the size in bits, not bytes. My old code used `MBIT` everywhere but when rewriting it for RIOT it tried to be clever…)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14084#discussion_r427413390
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200519/14d1fe34/attachment-0001.htm>


More information about the notifications mailing list