[riot-notifications] [RIOT-OS/RIOT] boards/stm32f4: Remove incorrect UART DMA config from stm32f4 boards (#14090)

Alexandre Abadie notifications at github.com
Tue May 19 21:08:13 CEST 2020


@aabadie commented on this pull request.



> @@ -69,15 +69,13 @@ static const uart_conf_t uart_config[] = {
         .tx_af      = GPIO_AF8,
         .bus        = APB2,
         .irqn       = USART6_IRQn,
-#ifdef UART_USE_DMA
-        .dma_stream = 14,
-        .dma_chan   = 5
+#ifdef MODULE_PERIPH_DMA
+        .dma        = DMA_STREAM_UNDEF,

```suggestion
        .dma        = DMA_STREAM_UNDEF,
        .dma_chan   = 0,  /* or maybe .dma_chan = UINT8_MAX, ? */
```
here and below ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14090#pullrequestreview-414743618
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200519/106c7538/attachment.htm>


More information about the notifications mailing list