[riot-notifications] [RIOT-OS/RIOT] pkg/openwsn: re-integrate the network stack as a package (#13824)

Francisco notifications at github.com
Wed May 20 10:30:06 CEST 2020


@fjmolinas commented on this pull request.



> +    if (IS_USED(MODULE_OPENWSN_LEDPINS)) {
+        if (configuration.error != GPIO_UNDEF) {
+            gpio_init(configuration.error, GPIO_OUT);
+        }
+        else if (configuration.sync != GPIO_UNDEF) {
+            gpio_init(configuration.sync, GPIO_OUT);
+        }
+        else if (configuration.radio != GPIO_UNDEF) {
+            gpio_init(configuration.radio, GPIO_OUT);
+        }
+        else if (configuration.debug != GPIO_UNDEF) {
+            gpio_init(configuration.debug, GPIO_OUT);
+        }
+        leds_all_off();

Just saw this, should not be else if. Also I'll apply Kaspar suggestion for the debugpins here as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13824#pullrequestreview-415106191
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200520/2479eb26/attachment-0001.htm>


More information about the notifications mailing list