[riot-notifications] [RIOT-OS/RIOT] gnrc/tcp : Expose configurations to Kconfig (#14126)

Leandro Lanzieri notifications at github.com
Mon May 25 12:27:35 CEST 2020


@leandrolanzieri commented on this pull request.



> + *
+ *

?

> + * where alpha and beta are constants, and R' is the instantaneous RTT value.
+ *
+ * RTO is then calculated as :
+ *
+ *     RTO <- SRTT + max (G, K*RTTVAR)
+ *
+ * where K is a constant, and G is clock granularity in seconds.

Maybe you can add references to the macros that represent these parameters

> @@ -102,6 +130,7 @@ extern "C" {
 
 /**
  * @brief Alpha value for RTO calculation, default is 1/8
+ *

Extra line

> @@ -186,8 +186,9 @@ static int _gnrc_tcp_open(gnrc_tcp_tcb_t *tcb, const gnrc_tcp_ep_t *remote,
         tcb->peer_port = remote->port;
 
         /* Setup connection timeout: Put timeout message in TCBs mbox on expiration */
-        _setup_timeout(&connection_timeout, GNRC_TCP_CONNECTION_TIMEOUT_DURATION,
-                       _cb_mbox_put_msg, &connection_timeout_arg);
+        _setup_timeout(&connection_timeout, \

Here and bellow, please keep the current style of the file for multiline function call. I think you can drop the `\` as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14126#pullrequestreview-417607357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200525/5325ee26/attachment.htm>


More information about the notifications mailing list