[riot-notifications] [RIOT-OS/RIOT] nanocoap: bugfix token overflow (#14075)

Martine Lenders notifications at github.com
Mon May 25 15:19:22 CEST 2020


@miri64 commented on this pull request.



>          pkt_pos += coap_get_token_len(pkt);
     }
     else {
-        pkt->token = NULL;
+        DEBUG("tkl invalid\n");

Please prefix those DEBUG messages. Also, I would prefer to write out those abbreviations.

```suggestion
        DEBUG("nanocoap: token length invalid\n");
```

>          }
     }
 
+    if (pkt_pos > pkt_end) {
+        DEBUG("bad pkt len\n");

```suggestion
        DEBUG("nanocoap: bad packet length\n");
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14075#pullrequestreview-417705352
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200525/a551446a/attachment-0001.htm>


More information about the notifications mailing list