[riot-notifications] [RIOT-OS/RIOT] cpu/stm32: get the cpuid address from the UID_BASE constant defined in CMSIS (#14140)

Alexandre Abadie notifications at github.com
Tue May 26 10:18:37 CEST 2020

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

This is PR is an attempt to remove the hardcoded cpuid address defined for each STM32 families (and sometimes for a specific model).
Some CMSIS headers were a bit outdated so had to be updated: all f2xx, f103xx, f334, f72x.

While updating the CMSIS, I also noticed that all CCR registers for timer peripherals have to be patched. I'd like to revert this and adapt the timer peripheral driver accordingly.

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

- A green Murdock
- Verify that `tests/periph_cpuid` is still working and return the same result compared to master
- Maybe also run `compile_and_test_for_board.py` on some of the affected STM32 boards.

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references


Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * cpu/stm32: use UID_BASE from CMSIS when not defined
  * cpu/stm32: use UID_BASE when possible
  * cpu/stm32: update stm32f2xx vendor headers
  * cpu/stm32: remove not needed periph_cpu.h for f7
  * cpu/stm32: update stm32f2 vendor headers
  * cpu/stm32: update stm32f334 vendor header
  * cpu/stm32: remove not needed periph_cpu.h for f3
  * cpu/stm32: update vendor headers for f0
  * cpu/stm32: remove hardcoded cpuid addr for f0
  * cpu/stm32: update vendor headers for f1
  * cpu/stm32: remove hardcoded cpuid addr for f1

-- File Changes --

    M cpu/stm32/include/periph/f0/periph_cpu.h (5)
    M cpu/stm32/include/periph/f1/periph_cpu.h (5)
    M cpu/stm32/include/periph/f2/periph_cpu.h (5)
    D cpu/stm32/include/periph/f3/periph_cpu.h (36)
    M cpu/stm32/include/periph/f4/periph_cpu.h (5)
    D cpu/stm32/include/periph/f7/periph_cpu.h (41)
    M cpu/stm32/include/periph/l0/periph_cpu.h (5)
    M cpu/stm32/include/periph/l1/periph_cpu.h (10)
    M cpu/stm32/include/periph/l4/periph_cpu.h (5)
    D cpu/stm32/include/periph/wb/periph_cpu.h (37)
    M cpu/stm32/include/periph_cpu.h (15)
    M cpu/stm32/include/vendor/stm32f042x6.h (12882)
    M cpu/stm32/include/vendor/stm32f051x8.h (7912)
    M cpu/stm32/include/vendor/stm32f103xb.h (12593)
    M cpu/stm32/include/vendor/stm32f103xe.h (10101)
    M cpu/stm32/include/vendor/stm32f205xx.h (16840)
    M cpu/stm32/include/vendor/stm32f207xx.h (18513)
    M cpu/stm32/include/vendor/stm32f215xx.h (17099)
    M cpu/stm32/include/vendor/stm32f217xx.h (18486)
    M cpu/stm32/include/vendor/stm32f334x8.h (18753)
    M cpu/stm32/include/vendor/stm32f722xx.h (10902)
    M cpu/stm32/include/vendor/stm32f723xx.h (10976)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200526/b85bb7c0/attachment.htm>

More information about the notifications mailing list