[riot-notifications] [RIOT-OS/RIOT] ztimer: relocate PSEUDOMULDES definitions (#14123)

Francisco notifications at github.com
Tue May 26 13:36:04 CEST 2020


> @leandrolanzieri and @fjmolinas, care to share your thoughts on this?

Up to recently pseudo-module where declarative I preferred that, so I lean more to what I suggested in https://github.com/RIOT-OS/RIOT/pull/13661#issuecomment-630776417, but its not something I would insist on.

`PSEUDOMODULES` are already defined in  `Makefile.include`s so I think it makes makes sense to keep these conditional definitions in `Makefile.include `instead of in `pseudomodules.inc.mk`. But the problem is that `Makefile.include` is not included after `Makefile.dep` for `CPU`s and `BOARD`s. So the problem is that now that it is not declarative we care about inclusion order, because of that until this inclusion order is fixed I would have them in `pseudomodules.inc.mk` as @maribu suggested.

But for me this is just an argument in favor of keeping them declarative.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14123#issuecomment-633970462
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200526/8e97f470/attachment.htm>


More information about the notifications mailing list