[riot-notifications] [RIOT-OS/RIOT] STM32_common/dma: Optimize the latency in the hot path (#14096)

Alexandre Abadie notifications at github.com
Wed May 27 09:42:49 CEST 2020


I tested this PR on `iotlab-m3` (UART) and `stm32f429i-disc1` (ILI9341 screen via SPI) and both worked.

I have a few comments on several points:
1. What happens if the device goes to sleep mode (STOP). Shouldn't the DMA be powered on again after a wake up ? It seems dangerous to me to only call `dma_poweron` in `dma_init`.
5. configure is split in setup/prepare but in the change, both functions are called one after the other. Do you have a use case where prepare is called somewhere else ? Or maybe you forgot to push dma_prepare additions in DMA related peripheral (UART, SPI) ?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14096#issuecomment-634487962
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200527/3a727d01/attachment.htm>


More information about the notifications mailing list