[riot-notifications] [RIOT-OS/RIOT] STM32_common/dma: Optimize the latency in the hot path (#14096)
notifications at github.com
Wed May 27 09:42:49 CEST 2020
I tested this PR on `iotlab-m3` (UART) and `stm32f429i-disc1` (ILI9341 screen via SPI) and both worked.
I have a few comments on several points:
1. What happens if the device goes to sleep mode (STOP). Shouldn't the DMA be powered on again after a wake up ? It seems dangerous to me to only call `dma_poweron` in `dma_init`.
5. configure is split in setup/prepare but in the change, both functions are called one after the other. Do you have a use case where prepare is called somewhere else ? Or maybe you forgot to push dma_prepare additions in DMA related peripheral (UART, SPI) ?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications