[riot-notifications] [RIOT-OS/RIOT] tinydtls: add `sock_async` support for `sock_dtls` (#12907)

Martine Lenders notifications at github.com
Wed May 27 16:03:40 CEST 2020


@miri64 commented on this pull request.



> +    sock_dtls_close(&_dtls_sock);
+    sock_udp_close(&_udp_sock);
+    _sending = false;

I was thinking about that, but the semantics of this is different. `_close_sock()` is for when the UDP `sock` is not available, which isn't the case here. Also: I'm not even sure we keep this (see commit message, also it would make much more sense from the usual flow to make the server asynchronous). So please focus your review on the `sock_async` integration first and then we can discuss the application.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12907#discussion_r431156611
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200527/89a6a5ab/attachment-0001.htm>


More information about the notifications mailing list