[riot-notifications] [RIOT-OS/RIOT] gnrc/pktbuf : Expose Configurations to Kconfig (#14056)

Leandro Lanzieri notifications at github.com
Thu May 28 09:46:13 CEST 2020


@leandrolanzieri requested changes on this pull request.



> @@ -0,0 +1,24 @@
+# Copyright (c) 2020 Freie Universitaet Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+menuconfig KCONFIG_MODULE_GNRC_PKTBUF_STATIC
+    bool "Configure GNRC_PKTBUF"
+    depends on MODULE_GNRC_PKTBUF

If this will only expose options for the static pktbuf, then I think it should depend on it instead:
`depends on MODULE_GNRC_PKTBUF_STATIC`

> +ifdef CONFIG_GNRC_PKTBUF_SIZE
+  CFLAGS += -DCONFIG_GNRC_PKTBUF_SIZE=$(CONFIG_GNRC_PKTBUF_SIZE)
 endif

This will clash with the value provided by Kconfig. I think we should keep the makefile variable name
```suggestion
ifdef GNRC_PKTBUF_SIZE
  CFLAGS += -DCONFIG_GNRC_PKTBUF_SIZE=$(GNRC_PKTBUF_SIZE)
endif
```
Also, needs to be changed back on other makefiles that include this (like `tests/driver_xbee/Makefile`).

> @@ -0,0 +1,24 @@
+# Copyright (c) 2020 Freie Universitaet Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+menuconfig KCONFIG_MODULE_GNRC_PKTBUF_STATIC
+    bool "Configure GNRC_PKTBUF"

Here and bellow
```suggestion
    bool "Configure the GNRC Packet Buffer"
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14056#pullrequestreview-419849676
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200528/4a6b5254/attachment.htm>


More information about the notifications mailing list