[riot-notifications] [RIOT-OS/RIOT] gnrc/tcp : Expose configurations to Kconfig (#14126)

Simon Brummer notifications at github.com
Fri May 29 08:29:04 CEST 2020


@brummer-simon requested changes on this pull request.

I have some small change requests aside from that good work.

>  #endif
 
 /**
  * @brief Default receive window size
  */
 #ifndef GNRC_TCP_DEFAULT_WINDOW
-#define GNRC_TCP_DEFAULT_WINDOW (GNRC_TCP_MSS * GNRC_TCP_MSS_MULTIPLICATOR)
+#define GNRC_TCP_DEFAULT_WINDOW (GNRC_TCP_MSS * CONFIG_GNRC_TCP_MSS_MULTIPLICATOR)
 #endif
 

This value marks the maximum amount of bytes that can be received from the peer at a given moment.
In general it makes sence to elide this value from "n times maximum segment size" however this parameter influences TCPs behavior significantly. Making in configurable might have its benefits.  

> +config GNRC_TCP_MSL
+    int "Maximum segment lifetime (MSL) in microseconds"
+    default 30000000
+    help
+        Maximum segment lifetime (MSL) in microseconds. Default value is 30
+        seconds.
+
+config GNRC_TCP_MSS_MULTIPLICATOR
+    int "Number of MSS sized packets stored in receive buffer"
+    default 1
+    help
+        Configure MSS Multiplicator i.e. number of MSS sized packets stored in
+        receive buffer.
+
+config GNRC_TCP_RCV_BUFFERS
+    int "Number of preallocated receive buffers"

Its still the same description

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14126#pullrequestreview-420678728
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200528/9b167c7b/attachment.htm>


More information about the notifications mailing list