[riot-notifications] [RIOT-OS/RIOT] boards/samr21-xpro: Model features in Kconfig (#13404)

Marian Buschsieweke notifications at github.com
Fri May 29 09:30:06 CEST 2020


@maribu commented on this pull request.

See inline comment

> @@ -5,5 +5,5 @@
 # directory for more details.
 
 config WDT_WARNING_PERIOD
-    depends on HAS_WDT_WARNING_PERIOD && KCONFIG_MODULE_PERIPH_WDT
+    depends on WDT_WARNING_PERIOD_SUPPORT && KCONFIG_MODULE_PERIPH_WDT

Wouldn't it be easier for the future specify a list of well known prefixes? E.g. `HAS_` apparently is already one of these prefixes. And if `HAS_` does not apply here, I suggest to specify a second prefix. It would be needed to document this, so that the prefixes are used correctly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13404#pullrequestreview-420710489
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200529/ce056588/attachment.htm>


More information about the notifications mailing list