[riot-notifications] [RIOT-OS/RIOT] boards/samr21-xpro: Model features in Kconfig (#13404)

Marian Buschsieweke notifications at github.com
Fri May 29 09:53:28 CEST 2020


@maribu commented on this pull request.



> @@ -5,5 +5,5 @@
 # directory for more details.
 
 config WDT_WARNING_PERIOD
-    depends on HAS_WDT_WARNING_PERIOD && KCONFIG_MODULE_PERIPH_WDT
+    depends on WDT_WARNING_PERIOD_SUPPORT && KCONFIG_MODULE_PERIPH_WDT

Both sound good to me. Maybe it could be defined that a verb as first word in a symbol is reserved for well known prefixes? All other Kconfig symbols present so far seem to be something like `CPU_...`, `APP_...`, `<MODULE_NAME>_...`. If I didn't overlook anything, the only `<verb>_` is `HAS_` so far.

My gut feeling is that "regular" symbol names would never look like `<verb>_...` anyway. And with that reservation in place, developers would recognize a new well known prefix as such even if they see it for the very first time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13404#discussion_r432315680
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200529/2fc17109/attachment.htm>


More information about the notifications mailing list