[riot-notifications] [RIOT-OS/RIOT] boards/samr21-xpro: Model features in Kconfig (#13404)

Marian Buschsieweke notifications at github.com
Fri May 29 11:09:12 CEST 2020


@maribu commented on this pull request.



> @@ -5,5 +5,5 @@
 # directory for more details.
 
 config WDT_WARNING_PERIOD
-    depends on HAS_WDT_WARNING_PERIOD && KCONFIG_MODULE_PERIPH_WDT
+    depends on WDT_WARNING_PERIOD_SUPPORT && KCONFIG_MODULE_PERIPH_WDT

> Indeed `HAS_` is the only `<verb>_` so far, but there are other well-known prefixes already

It might still be sensible to reserve `<verb>_` for prefixes; that reservation would not imply that prefixes are limited to this.

(It would however likely be *feasible* to limit prefixes to a `<verb>_` pattern. E.g. `MODULE_` could be replaced by `USES_MODULE_`, `PKG_` to `USES_PKG_`. But *feasible* does not imply it is *sensible* :-))

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13404#discussion_r432355613
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200529/7f01928f/attachment.htm>


More information about the notifications mailing list