[riot-notifications] [RIOT-OS/RIOT] pkg/fatfs/fatfs_vfs: fix flag translation in _open (#14175)

benpicco notifications at github.com
Fri May 29 19:14:03 CEST 2020


@benpicco commented on this pull request.



> +    FILE* fl;
+    char buf[sizeof(test_txt) + sizeof(test_txt2)];
+    print_test_result("test_newlib__mount", vfs_mount(&_test_vfs_mount) == 0);
+
+    /* try to open file that doesn't exist */
+    fl = fopen(FULL_FNAME_NXIST, "r");
+    print_test_result("test_newlib__fopen", fl == NULL);
+
+    /* open file RO */
+    fl = fopen(FULL_FNAME1, "r");
+    print_test_result("test_newlib__fopen_r", fl != NULL);
+    print_test_result("test_newlib__fclose_r", fclose(fl) == 0);
+
+    /* create new file write and check content */
+    remove(FULL_FNAME2);
+    fl = fopen(FULL_FNAME2, "w+");

You should `close(fl)` before.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14175#pullrequestreview-421139888
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200529/9d48a288/attachment.htm>


More information about the notifications mailing list