[riot-notifications] [RIOT-OS/RIOT] pkg/fatfs/fatfs_vfs: fix flag translation in _open (#14175)

benpicco notifications at github.com
Fri May 29 19:17:58 CEST 2020


@benpicco commented on this pull request.



> @@ -295,6 +295,58 @@ static void test_create(void)
     print_test_result("test_create__umount", vfs_umount(&_test_vfs_mount) == 0);
 }
 
+#ifdef MODULE_NEWLIB
+static void test_newlib(void)
+{
+    FILE* fl;
+    char buf[sizeof(test_txt) + sizeof(test_txt2)];
+    print_test_result("test_newlib__mount", vfs_mount(&_test_vfs_mount) == 0);
+
+    /* try to open file that doesn't exist */
+    fl = fopen(FULL_FNAME_NXIST, "r");
+    print_test_result("test_newlib__fopen", fl == NULL);
+

`cppcheck` complains about a resource leak, so you should probably add 

```C
if (fl) {
    fclose(fl);
}
```

just in case

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14175#pullrequestreview-421142521
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200529/997b37b6/attachment.htm>


More information about the notifications mailing list