[riot-notifications] [RIOT-OS/RIOT] pkg/fatfs/fatfs_vfs: fix flag translation in _open (#14175)

benpicco notifications at github.com
Fri May 29 19:23:30 CEST 2020


I ran the new test on `same54-xpro` with an SD card attached.

<details><summary>before</summary>

```
2020-05-29 19:19:33,954 # test_mount__mount:[OK]
2020-05-29 19:19:33,956 # test_mount__umount:[OK]
2020-05-29 19:19:33,963 # test_open__mount:[OK]
2020-05-29 19:19:33,967 # test_open__open:[OK]
2020-05-29 19:19:33,969 # test_open__open_ro:[OK]
2020-05-29 19:19:33,971 # test_open__close_ro:[OK]
2020-05-29 19:19:33,973 # test_open__open_wo:[OK]
2020-05-29 19:19:33,975 # test_open__close_wo:[OK]
2020-05-29 19:19:33,977 # test_open__open_rw:[OK]
2020-05-29 19:19:33,980 # test_open__close_rw:[OK]
2020-05-29 19:19:33,982 # test_open__umount:[OK]
2020-05-29 19:19:33,988 # test_rw__mount:[OK]
2020-05-29 19:19:33,992 # test_rw__open_ro:[OK]
2020-05-29 19:19:33,995 # test_rw__read_ro:[OK]
2020-05-29 19:19:33,997 # test_rw__write_ro:[OK]
2020-05-29 19:19:33,999 # test_rw__close_ro:[OK]
2020-05-29 19:19:34,003 # test_rw__open_wo:[OK]
2020-05-29 19:19:34,005 # test_rw__read_wo:[OK]
2020-05-29 19:19:34,007 # test_rw__close_wo:[OK]
2020-05-29 19:19:34,009 # test_rw__open_rw:[OK]
2020-05-29 19:19:34,012 # test_rw__read_rw:[OK]
2020-05-29 19:19:34,014 # test_rw__write_rw:[OK]
2020-05-29 19:19:34,016 # test_rw__lseek:[OK]
2020-05-29 19:19:34,018 # test_rw__read_rw:[OK]
2020-05-29 19:19:34,077 # test_rw__close_rw:[OK]
2020-05-29 19:19:34,079 # test_rw__open_rwc:[OK]
2020-05-29 19:19:34,093 # test_rw__write_rwc:[OK]
2020-05-29 19:19:34,096 # test_rw__lseek_rwc:[OK]
2020-05-29 19:19:34,098 # test_rw__read_rwc:[OK]
2020-05-29 19:19:34,112 # test_rw__close_rwc:[OK]
2020-05-29 19:19:34,114 # test_rw__umount:[OK]
2020-05-29 19:19:34,121 # test_dir__mount:[OK]
2020-05-29 19:19:34,123 # test_dir__opendir:[OK]
2020-05-29 19:19:34,127 # test_dir__readdir1:[OK]
2020-05-29 19:19:34,129 # test_dir__readdir2:[OK]
2020-05-29 19:19:34,131 # test_dir__readdir_name:[OK]
2020-05-29 19:19:34,134 # test_dir__readdir3:[FAILED]
2020-05-29 19:19:34,136 # test_dir__closedir:[OK]
2020-05-29 19:19:34,138 # test_dir__umount:[OK]
2020-05-29 19:19:34,144 # test_rename__mount:[OK]
2020-05-29 19:19:34,152 # test_rename__rename:[OK]
2020-05-29 19:19:34,154 # test_rename__opendir:[OK]
2020-05-29 19:19:34,157 # test_rename__readdir1:[OK]
2020-05-29 19:19:34,159 # test_rename__readdir2:[OK]
2020-05-29 19:19:34,162 # test_rename__check_name:[OK]
2020-05-29 19:19:34,164 # test_rename__readdir3:[FAILED]
2020-05-29 19:19:34,167 # test_rename__closedir:[OK]
2020-05-29 19:19:34,169 # test_rename__umount:[OK]
2020-05-29 19:19:34,176 # test_unlink__mount:[OK]
2020-05-29 19:19:34,196 # test_unlink__unlink1:[OK]
2020-05-29 19:19:34,216 # test_unlink__unlink2:[OK]
2020-05-29 19:19:34,218 # test_unlink__opendir:[OK]
2020-05-29 19:19:34,223 # test_unlink__readdir:[FAILED]
2020-05-29 19:19:34,225 # test_unlink__closedir:[OK]
2020-05-29 19:19:34,227 # test_unlink__umount:[OK]
2020-05-29 19:19:34,234 # test_mkrmdir__mount:[OK]
2020-05-29 19:19:34,363 # test_mkrmdir__mkdir:[OK]
2020-05-29 19:19:34,367 # test_mkrmdir__opendir1:[OK]
2020-05-29 19:19:34,370 # test_mkrmdir__closedir:[OK]
2020-05-29 19:19:34,388 # test_mkrmdir__rmdir:[OK]
2020-05-29 19:19:34,393 # test_mkrmdir__opendir2:[OK]
2020-05-29 19:19:34,395 # test_mkrmdir__umount:[OK]
2020-05-29 19:19:34,402 # test_create__mount:[OK]
2020-05-29 19:19:34,406 # test_create__open_wo:[OK]
2020-05-29 19:19:34,418 # test_create__write_wo:[OK]
2020-05-29 19:19:34,430 # test_create__close_wo:[OK]
2020-05-29 19:19:34,432 # test_create__umount:[OK]
2020-05-29 19:19:34,440 # test_newlib__mount:[OK]
2020-05-29 19:19:34,444 # test_newlib__fopen:[OK]
2020-05-29 19:19:34,446 # test_newlib__fopen_r:[OK]
2020-05-29 19:19:34,448 # test_newlib__fclose_r:[OK]
2020-05-29 19:19:34,451 # test_newlib__fopen_w:[OK]
2020-05-29 19:19:34,453 # test_newlib__fputs_w:[OK]
2020-05-29 19:19:34,465 # test_newlib__fread_w:[OK]
2020-05-29 19:19:34,468 # test_newlib__strcmp_w:[OK]
2020-05-29 19:19:34,530 # test_newlib__fclose_w:[OK]
2020-05-29 19:19:34,547 # test_newlib__remove:[OK]
2020-05-29 19:19:34,551 # test_newlib__fopen_a:[OK]
2020-05-29 19:19:34,554 # test_newlib__fputs_a:[OK]
2020-05-29 19:19:34,576 # test_newlib__fclose_a:[OK]
2020-05-29 19:19:34,581 # test_newlib__fopen_a2:[FAILED]
2020-05-29 19:19:34,583 # test_newlib__fputs_a2:[OK]
2020-05-29 19:19:34,583 # 
2020-05-29 19:19:34,585 # Context before hardfault:
2020-05-29 19:19:34,587 #    r0: 0x2000025c
2020-05-29 19:19:34,589 #    r1: 0x00000000
2020-05-29 19:19:34,590 #    r2: 0x00000611
2020-05-29 19:19:34,592 #    r3: 0x1ffffbef
2020-05-29 19:19:34,593 #   r12: 0x00000000
2020-05-29 19:19:34,595 #    lr: 0x00005819
2020-05-29 19:19:34,596 #    pc: 0x00000000
2020-05-29 19:19:34,598 #   psr: 0x200f0000
2020-05-29 19:19:34,598 # 
2020-05-29 19:19:34,599 # FSR/FAR:
2020-05-29 19:19:34,601 #  CFSR: 0x00020000
2020-05-29 19:19:34,602 #  HFSR: 0x40000000
2020-05-29 19:19:34,604 #  DFSR: 0x00000000
2020-05-29 19:19:34,605 #  AFSR: 0x00000000
2020-05-29 19:19:34,606 # Misc
2020-05-29 19:19:34,607 # EXC_RET: 0xfffffffd
2020-05-29 19:19:34,612 # Attempting to reconstruct state for debugging...
2020-05-29 19:19:34,612 # In GDB:
2020-05-29 19:19:34,614 #   set $pc=0x0
2020-05-29 19:19:34,614 #   frame 0
2020-05-29 19:19:34,615 #   bt
2020-05-29 19:19:34,615 # 
2020-05-29 19:19:34,619 # ISR stack overflowed by at least 16 bytes.
```
</details>

<details><summary>with this patch</summary>

```
2020-05-29 19:20:04,308 # test_mount__mount:[OK]
2020-05-29 19:20:04,311 # test_mount__umount:[OK]
2020-05-29 19:20:04,317 # test_open__mount:[OK]
2020-05-29 19:20:04,321 # test_open__open:[OK]
2020-05-29 19:20:04,323 # test_open__open_ro:[OK]
2020-05-29 19:20:04,325 # test_open__close_ro:[OK]
2020-05-29 19:20:04,327 # test_open__open_wo:[OK]
2020-05-29 19:20:04,329 # test_open__close_wo:[OK]
2020-05-29 19:20:04,332 # test_open__open_rw:[OK]
2020-05-29 19:20:04,334 # test_open__close_rw:[OK]
2020-05-29 19:20:04,336 # test_open__umount:[OK]
2020-05-29 19:20:04,342 # test_rw__mount:[OK]
2020-05-29 19:20:04,346 # test_rw__open_ro:[OK]
2020-05-29 19:20:04,349 # test_rw__read_ro:[OK]
2020-05-29 19:20:04,351 # test_rw__write_ro:[OK]
2020-05-29 19:20:04,353 # test_rw__close_ro:[OK]
2020-05-29 19:20:04,357 # test_rw__open_wo:[OK]
2020-05-29 19:20:04,359 # test_rw__read_wo:[OK]
2020-05-29 19:20:04,361 # test_rw__close_wo:[OK]
2020-05-29 19:20:04,363 # test_rw__open_rw:[OK]
2020-05-29 19:20:04,366 # test_rw__read_rw:[OK]
2020-05-29 19:20:04,368 # test_rw__write_rw:[OK]
2020-05-29 19:20:04,370 # test_rw__lseek:[OK]
2020-05-29 19:20:04,372 # test_rw__read_rw:[OK]
2020-05-29 19:20:04,382 # test_rw__close_rw:[OK]
2020-05-29 19:20:04,383 # test_rw__open_rwc:[OK]
2020-05-29 19:20:04,388 # test_rw__write_rwc:[OK]
2020-05-29 19:20:04,390 # test_rw__lseek_rwc:[OK]
2020-05-29 19:20:04,392 # test_rw__read_rwc:[OK]
2020-05-29 19:20:04,401 # test_rw__close_rwc:[OK]
2020-05-29 19:20:04,403 # test_rw__umount:[OK]
2020-05-29 19:20:04,410 # test_dir__mount:[OK]
2020-05-29 19:20:04,412 # test_dir__opendir:[OK]
2020-05-29 19:20:04,416 # test_dir__readdir1:[OK]
2020-05-29 19:20:04,418 # test_dir__readdir2:[OK]
2020-05-29 19:20:04,421 # test_dir__readdir_name:[OK]
2020-05-29 19:20:04,423 # test_dir__readdir3:[FAILED]
2020-05-29 19:20:04,425 # test_dir__closedir:[OK]
2020-05-29 19:20:04,427 # test_dir__umount:[OK]
2020-05-29 19:20:04,434 # test_rename__mount:[OK]
2020-05-29 19:20:04,441 # test_rename__rename:[OK]
2020-05-29 19:20:04,443 # test_rename__opendir:[OK]
2020-05-29 19:20:04,445 # test_rename__readdir1:[OK]
2020-05-29 19:20:04,448 # test_rename__readdir2:[OK]
2020-05-29 19:20:04,450 # test_rename__check_name:[OK]
2020-05-29 19:20:04,453 # test_rename__readdir3:[FAILED]
2020-05-29 19:20:04,455 # test_rename__closedir:[OK]
2020-05-29 19:20:04,457 # test_rename__umount:[OK]
2020-05-29 19:20:04,465 # test_unlink__mount:[OK]
2020-05-29 19:20:04,481 # test_unlink__unlink1:[OK]
2020-05-29 19:20:04,499 # test_unlink__unlink2:[OK]
2020-05-29 19:20:04,501 # test_unlink__opendir:[OK]
2020-05-29 19:20:04,506 # test_unlink__readdir:[FAILED]
2020-05-29 19:20:04,508 # test_unlink__closedir:[OK]
2020-05-29 19:20:04,510 # test_unlink__umount:[OK]
2020-05-29 19:20:04,517 # test_mkrmdir__mount:[OK]
2020-05-29 19:20:04,629 # test_mkrmdir__mkdir:[OK]
2020-05-29 19:20:04,634 # test_mkrmdir__opendir1:[OK]
2020-05-29 19:20:04,636 # test_mkrmdir__closedir:[OK]
2020-05-29 19:20:04,654 # test_mkrmdir__rmdir:[OK]
2020-05-29 19:20:04,659 # test_mkrmdir__opendir2:[OK]
2020-05-29 19:20:04,661 # test_mkrmdir__umount:[OK]
2020-05-29 19:20:04,668 # test_create__mount:[OK]
2020-05-29 19:20:04,672 # test_create__open_wo:[FAILED]
2020-05-29 19:20:04,675 # test_create__write_wo:[FAILED]
2020-05-29 19:20:04,678 # test_create__close_wo:[FAILED]
2020-05-29 19:20:04,680 # test_create__umount:[OK]
2020-05-29 19:20:04,687 # test_newlib__mount:[OK]
2020-05-29 19:20:04,691 # test_newlib__fopen:[OK]
2020-05-29 19:20:04,693 # test_newlib__fopen_r:[FAILED]
2020-05-29 19:20:04,696 # test_newlib__fclose_r:[OK]
2020-05-29 19:20:04,698 # test_newlib__fopen_w:[OK]
2020-05-29 19:20:04,700 # test_newlib__fputs_w:[OK]
2020-05-29 19:20:04,762 # test_newlib__fread_w:[OK]
2020-05-29 19:20:04,764 # test_newlib__strcmp_w:[OK]
2020-05-29 19:20:04,776 # test_newlib__fclose_w:[OK]
2020-05-29 19:20:04,793 # test_newlib__remove:[OK]
2020-05-29 19:20:04,798 # test_newlib__fopen_a:[OK]
2020-05-29 19:20:04,800 # test_newlib__fputs_a:[OK]
2020-05-29 19:20:04,823 # test_newlib__fclose_a:[OK]
2020-05-29 19:20:04,827 # test_newlib__fopen_a2:[OK]
2020-05-29 19:20:04,829 # test_newlib__fputs_a2:[OK]
2020-05-29 19:20:04,833 # test_newlib__fread_a2:[OK]
2020-05-29 19:20:04,836 # test_newlib__strcmp_a2:[OK]
2020-05-29 19:20:04,838 # test_newlib__strcmp_a2:[OK]
2020-05-29 19:20:04,848 # test_newlib__fclose_a2:[OK]
2020-05-29 19:20:04,863 # test_newlib__remove:[OK]
2020-05-29 19:20:04,865 # test_newlib__umount:[OK]
2020-05-29 19:20:04,866 # Test end.
```
</details>

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14175#issuecomment-636090455
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20200529/dc117481/attachment-0001.htm>


More information about the notifications mailing list