[riot-notifications] [RIOT-OS/RIOT] black/white e-Paper/e-Ink display driver (#12509)

Jean Pierre Dudey notifications at github.com
Mon Nov 2 10:28:16 CET 2020


@jeandudey approved this pull request.



> @@ -0,0 +1,17 @@
+include ../Makefile.tests_common
+
+BOARD := nucleo-f411re

```suggestion
BOARD ?= nucleo-f411re
```

To allow using other boards :wink: 

> @@ -0,0 +1,16 @@
+include ../Makefile.tests_common
+
+BOARD := nucleo-f411re

dito

> +    /* Give a low pulse on the reset pin */
+    if (dev->params.rst_pin != GPIO_UNDEF) {
+        gpio_clear(dev->params.rst_pin);
+        xtimer_usleep(EPD_BW_SPI_WAIT_RESET);
+        gpio_set(dev->params.rst_pin);
+    }

What about making this a function akin to `epd_bw_spi_swreset` like:

```c
void epd_bw_spi_hwreset(epd_bw_spi_t *dev)
{
    /* Give a low pulse on the reset pin */
    if (dev->params.rst_pin != GPIO_UNDEF) {
        gpio_clear(dev->params.rst_pin);
        xtimer_usleep(EPD_BW_SPI_WAIT_RESET);
        gpio_set(dev->params.rst_pin);
        xtimer_usleep(EPD_BW_SPI_WAIT_RESET);
    }
}
```

With an additional 1 ms wait time used/needed for SSD1608 IC drivers, this way to reset the device at `epd_bw_spi_init_[full/part]` (as done for SSD1608) and should do no harm for other ICs that don't have a reset pin nor are required to be reset at initialization.

> +    /* Give a low pulse on the reset pin */
+    if (dev->params.rst_pin != GPIO_UNDEF) {
+        gpio_clear(dev->params.rst_pin);
+        xtimer_usleep(EPD_BW_SPI_WAIT_RESET);
+        gpio_set(dev->params.rst_pin);
+    }

_Btw digging up in the deepest of the internet I've found a [datasheet for SSD1608](https://annejan.com/media/SSD1608_1.2.pdf) used on Waveshare 1.54 in e-Paper devices_ 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12509#pullrequestreview-521450920
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201102/83728c63/attachment-0001.htm>


More information about the notifications mailing list