[riot-notifications] [RIOT-OS/RIOT] drivers/mtd_spi_nor: enable 32 bit addressing, define WP and HOLD pins (#15360)

Bas Stottelaar notifications at github.com
Mon Nov 2 20:54:15 CET 2020


@basilfx commented on this pull request.



> +    /* CS */
+    DEBUG("mtd_spi_nor_init: CS init\n");
+    spi_init_cs(_get_spi(dev), dev->params->cs);

```suggestion
    DEBUG("mtd_spi_nor_init: init pins\n");

    /* CS */
    spi_init_cs(_get_spi(dev), dev->params->cs);
```

> @@ -378,6 +400,11 @@ static int mtd_spi_nor_power(mtd_dev_t *mtd, enum mtd_power_state power)
                 return -EIO;
             }
 #endif
+            /* enable 32 bit address mode */
+            if (dev->params->addr_width == 4) {

Would an additional `assert(dev->params->addr_width == 3 || dev->params->addr_width == 4)` help catch configuration issues?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15360#pullrequestreview-521946431
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201102/e7ead446/attachment-0001.htm>


More information about the notifications mailing list