[riot-notifications] [RIOT-OS/RIOT] drivers/mtd_spi_nor: enable 32 bit addressing, define WP and HOLD pins (#15360)

benpicco notifications at github.com
Mon Nov 2 21:03:23 CET 2020


@benpicco commented on this pull request.



> @@ -378,6 +400,11 @@ static int mtd_spi_nor_power(mtd_dev_t *mtd, enum mtd_power_state power)
                 return -EIO;
             }
 #endif
+            /* enable 32 bit address mode */
+            if (dev->params->addr_width == 4) {

Sure, can add.
Initially I wanted to allow for setting `addr_width = 0` in the config for auto detection (size > 16 MiB -> 4 byte addressing, otherwise 3 byte) but the `params` struct is read only.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15360#discussion_r516223043
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201102/807c6442/attachment.htm>


More information about the notifications mailing list