[riot-notifications] [RIOT-OS/RIOT] core: debug: remove parenthesis around ENABLE_DEBUG define (#15365)

Martine Lenders notifications at github.com
Tue Nov 3 12:19:24 CET 2020


> > This allows for ENABLE_DEBUG to not be defined before including debug.h when the same behavior as #define ENABLE_DEBUG 0 is desired.
> 
> > Removing a `#define ENABLE_DEBUG 0`, but not the `debug.h` should now be compilable.
> 
> I think it was like that due to this:
> 
> https://github.com/RIOT-OS/RIOT/pull/15365/files#diff-fa45c9a6099d12df1e96b263d7d9840d2fae684f3127857d7e44b7dcf2adcd23L67-L72

Not really sure what you mean... Please rephrase.

> > why introduce the extra dependency when the goal (compile time checking) is met already?
> > This is not replacing `#if DEFINE` with `if(DEFINE)`, it was already the latter, and the header made sure that ENABLE_DEBUG is always set.
> 
> True

Removed the `IS_ACTIVE()` changes, and thus this PR only removes the parenthesis around the `0` in the define.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15365#issuecomment-721055828
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201103/78d5a142/attachment.htm>


More information about the notifications mailing list