[riot-notifications] [RIOT-OS/RIOT] tests/driver_bme680: improve automated test script (#15372)

Alexandre Abadie notifications at github.com
Tue Nov 3 15:31:30 CET 2020

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

This PR improves the automated test script of `tests/driver_bme680` and also provides a minor enhancement of the test application (exit if driver initialization fails).

Otherwise flake8 raises:
tests/drivers/bme680/tests/01-run.py:19:19: W605 invalid escape sequence '\['
tests/drivers/bme680/tests/01-run.py:19:27: W605 invalid escape sequence '\]'

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

- A green Murdock
- Check the test script is still working. This is difficult without the hardware. I don't have it but to test the regexp, I modified the test application to print fake values before the driver initialization. The version of this PR should work.

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references

Raised when running the static test locally in #15358

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * tests/driver_bme680: improve automated test script
  * tests/driver_bme680: return if driver init failed

-- File Changes --

    M tests/driver_bme680/main.c (1)
    M tests/driver_bme680/tests/01-run.py (11)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201103/a40a2584/attachment.htm>

More information about the notifications mailing list