[riot-notifications] [RIOT-OS/RIOT] Particle boards: Support monofirmware builds and uploads (#12751)

benpicco notifications at github.com
Fri Nov 6 11:50:14 CET 2020


@benpicco commented on this pull request.



> + */
+
+/**
+ * @{
+ *
+ * @file
+ * @author  Christian Amsüss <chrysn at fsfe.org>
+ */
+
+#ifdef PARTICLE_MONOFIRMWARE
+#include <stdint.h>
+#include "vectors_cortexm.h"
+
+extern const void *_isr_vectors;
+
+/* As described in Particle's dynalib/inc/module_info.h (there under LGPL-3

That one also does not use `__attribute__ ((packed))` to get rid of implicit padding? 

> +#ifdef BOARD_PARTICLE_ARGON
+    .platform_id = 12,
+#endif
+#ifdef BOARD_PARTICLE_BORON
+    .platform_id = 13,
+#endif
+#ifdef BOARD_PARTICLE_XENON
+    .platform_id = 14,
+#endif

I'd put a `PARTICLE_PLATFORM_ID` define inside the header files of `particle-argon`,  `particle-boron`  `particle-xenon` instead, that way it's not hidden here if someone wants to add another particle board.

> +#endif
+#ifdef BOARD_PARTICLE_BORON
+    .platform_id = 13,
+#endif
+#ifdef BOARD_PARTICLE_XENON
+    .platform_id = 14,
+#endif
+
+    .module_index = 3, /* MOD_FUNC_MONO_FIRMWARE from dynalib/inc/module_info.h */
+};
+
+#else
+typedef int dont_be_pedantic;
+#endif
+
+/** @} */

Is there a way to signal the bootloader that it should not boot the firmware but stay in DFU mode, i.e. can you provide a `usb_board_reset_in_bootloader()` function? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12751#pullrequestreview-525037087
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201106/345ce23e/attachment.htm>


More information about the notifications mailing list