[riot-notifications] [RIOT-OS/RIOT] Particle boards: Support monofirmware builds and uploads (#12751)

benpicco notifications at github.com
Fri Nov 6 13:01:36 CET 2020


@benpicco commented on this pull request.



> + * @{
+ *
+ * @brief       Management of bootloader resets
+ *
+ * This implements a reset procedure read from the code of the particle device
+ * OS at https://github.com/particle-iot/device-os/ (version
+ * c21d5b8f39c8a013e19f904800808673f369c6e3), primarily from
+ * hal/inc/syshealth_hal.h and its linker script.
+ *
+ * @file
+ * @author      Christian Amsüss <chrysn at fsfe.org>
+ *
+ * @}
+ */
+
+#ifdef MODULE_USB_BOARD_RESET

No need for that, if `usb_board_reset_in_bootloader()` is not used the linker will just throw it out. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12751#pullrequestreview-525090647
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201106/e14b4b41/attachment.htm>


More information about the notifications mailing list