[riot-notifications] [RIOT-OS/RIOT] Particle boards: Support monofirmware builds and uploads (#12751)

chrysn notifications at github.com
Fri Nov 6 13:08:08 CET 2020

@chrysn commented on this pull request.

> -  # option is passed explicitly
-  FLASH_TARGET_TYPE ?= -t nrf52840
-  include $(RIOTMAKE)/tools/pyocd.inc.mk
-else ifeq (openocd,$(PROGRAMMER))
+  ROM_OFFSET = 0x30000
+  FW_ROM_LEN = 0xc4000
+  FLASHFILE = $(BINFILE)-checksummed
+  # Setting DFU_ARGS won't work as the implied --reset causes errors.
+  FFLAGS = -d 0x2B04:0xD00E -a 0 -s 0x30000:leave -D $(FLASHFILE)
+  PROGRAMMER = dfu-util
+  include $(RIOTMAKE)/tools/dfu.inc.mk
+  USEMODULE += usb_board_reset

Doesn't this only apply if cdc_acm_stdio is also active?

By default it isn't, and then the USB board reset mechanism doesn't apply. (I *do* think it should be default anyway here, but that's not what I'm fixing here; when it was in earlier versions of this, I was reaching too far for a single PR).

(And btw since the last fixup, the USEMODULE is in .dep where it should be according to murdock)

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201106/ddbdd16d/attachment.htm>

More information about the notifications mailing list