[riot-notifications] [RIOT-OS/RIOT] Particle boards: Support monofirmware builds and uploads (#12751)

[benpicco]

@benpicco commented on this pull request.



> -  # option is passed explicitly
-  FLASH_TARGET_TYPE ?= -t nrf52840
-  include $(RIOTMAKE)/tools/pyocd.inc.mk
-else ifeq (openocd,$(PROGRAMMER))
-  DEBUG_ADAPTER ?= dap
+ifeq (1,$(PARTICLE_MONOFIRMWARE))
+  CFLAGS += -DPARTICLE_MONOFIRMWARE
+  ROM_OFFSET = 0x30000
+  FW_ROM_LEN = 0xc4000
+  FLASHFILE = $(BINFILE)-checksummed
+  # Setting DFU_ARGS won't work as the implied --reset causes errors.
+  FFLAGS = -d 0x2B04:0xD00E -a 0 -s 0x30000:leave -D $(FLASHFILE)
+  PROGRAMMER = dfu-util
+  include $(RIOTMAKE)/tools/dfu.inc.mk
+
+  USEMODULE += usb_board_reset

> Doesn't this only apply if cdc_acm_stdio is also active?

You are right - I just checked the other boards though and they will always select it if their USB bootloader is selected as `$(PROGRAMMER)`.
That is not always correct. (but then again, there is no other reset method if you are using the usb bootloader, so at worst it will just not work)

> when it was in earlier versions of this, I was reaching too far for a single PR

fortunately now all you need to do is 

    include $(RIOTBOARD)/common/makefiles/stdio_cdc_acm.dep.mk


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12751#discussion_r518715572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201106/c0b4731a/attachment-0001.htm>