[riot-notifications] [RIOT-OS/RIOT] Particle boards: Support monofirmware builds and uploads (#12751)

benpicco notifications at github.com
Fri Nov 6 13:30:36 CET 2020


@benpicco commented on this pull request.



> @@ -2,5 +2,9 @@ ifneq (,$(filter saul_default,$(USEMODULE)))
   USEMODULE += saul_gpio
 endif
 
+ifeq (1,$(PARTICLE_MONOFIRMWARE))

Other boards do

```suggestion
ifneq (,$(filter stdio_cdc_acm,$(USEMODULE)))
```

 But turns out `usb_board_reset` does not depend on USB in any way, so your version is more correct. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12751#pullrequestreview-525108560
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201106/0d3e36ed/attachment.htm>


More information about the notifications mailing list