[riot-notifications] [RIOT-OS/RIOT] b/c/particle-mesh: Switch default stdio to USB (#15394)

Alexandre Abadie notifications at github.com
Fri Nov 6 15:23:56 CET 2020


@aabadie commented on this pull request.



> @@ -2,10 +2,6 @@
 BOARD_NRFANTENNA_DEFAULT ?= BUILTIN
 CFLAGS += -DBOARD_NRFANTENNA_DEFAULT=BOARD_NRFANTENNA_$(BOARD_NRFANTENNA_DEFAULT)
 
-# set default port depending on operating system
-PORT_LINUX ?= /dev/ttyUSB0
-PORT_DARWIN ?= $(firstword $(sort $(wildcard /dev/tty.SLAB_USBtoUART*)))
-
 # add the common header files to the include path
 INCLUDES += -I$(RIOTBOARD)/common/particle-mesh/include
 

IIRC, `Makefile.include` is handled after `Makefile.dep` now. So if PARTICLE_MONOFIRMWARE is set to 1 here but is checked in Makefile.dep like you suggested in https://github.com/RIOT-OS/RIOT/pull/15394#discussion_r518777729, that might not work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15394#discussion_r518782631
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201106/a8eaa539/attachment.htm>


More information about the notifications mailing list