[riot-notifications] [RIOT-OS/RIOT] cpu/cc2538: add riotboot feature (#15392)
notifications at github.com
Fri Nov 6 17:45:03 CET 2020
@benpicco commented on this pull request.
> @@ -1 +1,56 @@
+# Set ROM and RAM lengths according to CPU model
+ifneq (,$(filter cc2538nf11,$(CPU_MODEL)))
+ ifneq (,$(filter riotboot,$(FEATURES_USED)))
+ # If using riotboot loose 2 pages to not right over CCA section and
# If using riotboot loose 2 pages to not write over CCA section and
> + # If using riotboot loose 2 pages to not right over CCA section and
+ # keep page parity
+ ROM_LEN ?= 252K
Shouldn't we *always* prevent overwriting the last page then? So unconditionally subtracting 2k?
And the 2k in the start, aren't they taken into account if you set `ROM_OFFSET`?
That way, we wouldn't need to copy & paste this for every model
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications