[riot-notifications] [RIOT-OS/RIOT] cpu/msp430_common: Prevent conflicting defines (#15399)

Marian Buschsieweke notifications at github.com
Fri Nov 6 21:12:35 CET 2020


### Contribution description

`irq_arch.h` so far includes`cpu.h`, which in term includes the vendor header files. Those are needed to get the GIE `#define` (general interrupt enable bit). However, the vendor files use fancy defines like `#define N (0x0004)` that easily conflict with application code. Due to the widespread use of the IRQ API, it is better to not include the vendor files in `irq_arch.h`.

This PR adds a local `#define` for the GIE bit and uses this instead of including `cpu.h`.


### Testing procedure

Binaries shouldn't change.

### Issues/PRs references

Fixes compilation on MSP430 with https://github.com/RIOT-OS/RIOT/pull/15327
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/15399

-- Commit Summary --

  * cpu/msp430_common: Prevent conflicting defines

-- File Changes --

    M cpu/msp430_common/include/irq_arch.h (6)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/15399.patch
https://github.com/RIOT-OS/RIOT/pull/15399.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15399
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201106/4019a512/attachment.htm>


More information about the notifications mailing list