[riot-notifications] [RIOT-OS/RIOT] hacl: Patch to fix building where PRIx64 is absent (#15401)
notifications at github.com
Sun Nov 8 06:56:21 CET 2020
### Contribution description
Quoting the inner commit:
> Not all RIOT platforms provide a PRIx64 or even 64-bit printing.
> As the debug routines that actually use this definition are unlikely to
> be used with RIOT, providing a definition that builds (and, depending on
> platform support, may or may not produce correct output) is a suitable
### Testing procedure
$ make BOARD=nrf52840dongle -C tests/pkg_hacl all flash term
Help: Press s to start test, r to print it is ready
main(): This is RIOT! (Version: 2021.01-devel-726-g54078-hacl-provide-prix64)
OK (1 tests)
I'm wondering why this never came up during CI builds -- possibly it's due to differing versions of the C standard library.
### Issues/PRs references
This could certainly be fixed to use only 32-bit prints (as was in https://github.com/RIOT-OS/RIOT/pull/4405/files), and that can still be done, but honestly I don't even know what all I'd need to enable to actually test it (I don't expect that anyone debugs these innards of hacl on RIOT). Plus it'll need going through upstream and updating the package (maybe it isn't even there in the latest version), but this *right now* keeps applications that use hacl on embedded from upgrading RIOT, and the PR patches in a default PRIx64 to make things build.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* hacl: Patch to fix building where PRIx64 is absent
-- File Changes --
A pkg/hacl/patches/0002-RIOT-Provide-PRIx64-if-needed.patch (32)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications