[riot-notifications] [RIOT-OS/RIOT] periph_flashpage: Make pagewise API optional (#15412)

benpicco notifications at github.com
Mon Nov 9 18:22:14 CET 2020


@benpicco commented on this pull request.



> @@ -61,16 +61,25 @@ static inline void _erase(uint32_t *page_addr)
     irq_restore(state);
 }
 
+void flashpage_erase(int page)

Why not

```suggestion
void flashpage_erase(unsigned page)
```

Negative pages don't seem to be very useful. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15412#pullrequestreview-526482294
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201109/87e30a0a/attachment.htm>


More information about the notifications mailing list