[riot-notifications] [RIOT-OS/RIOT] sys/net/iee802154/radio: add IEEE802154_RADIO_INDICATION_CRC_ERROR (#15397)

José Alamos notifications at github.com
Tue Nov 10 11:44:09 CET 2020


@jia200x commented on this pull request.



> @@ -190,6 +194,26 @@ typedef enum {
      */
     IEEE802154_RADIO_INDICATION_RX_START,
 
+    /**
+     * @brief the transceiver received a frame with an invalid crc
+     *        and lies in the internal framebuffer.
+     *
+     * This indication should be generated only if the CRC is invalid and
+     * the frame passes the address matching filter (this includes ACK
+     * and Beacon frames). The latter only applies if the radio is not
+     * in promiscuous mode.
+     *
+     * The transceiver is in @ref IEEE802154_TRX_STATE_RX_ON state when
+     * this function is called, but with framebuffer protection (either
+     * dynamic framebuffer protection or disabled RX). Thus, the frame
+     * won't be overwritten before calling @ref ieee802154_radio_indication_crc_error
+     * function. However, @ref ieee802154_radio_indication_crc_error

We removed the "indication" procedure in https://github.com/RIOT-OS/RIOT/pull/15228. I would suggest to do the same here (e.g state that `ieee802154_radio_request_set_trx_state` should be called in case this is received)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15397#pullrequestreview-527074002
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201110/cf94c370/attachment-0001.htm>


More information about the notifications mailing list