[riot-notifications] [RIOT-OS/RIOT] makefiles/tools/cc2538-bsl: use --write-erase to avoid mass erase (#15396)

[Alexandre Abadie]

@aabadie commented on this pull request.



> @@ -17,10 +17,8 @@ $(RIOTTOOLS)/pic32prog/pic32prog: $(RIOTTOOLS)/pic32prog/Makefile
 	$(MAKE) -C $(@D)
 	@echo "[INFO] $(@F) binary successfully built!"
 
-$(RIOTTOOLS)/cc2538-bsl/cc2538-bsl.py:
-	@echo "[INFO] cc2538-bsl.py not found - fetching it from GitHub now"
-	CC= CFLAGS= $(MAKE) -C $(RIOTTOOLS)/cc2538-bsl
-	@echo "[INFO] cc2538-bsl.py successfully fetched!"
+$(RIOTTOOLS)/cc2538-bsl/cc2538-bsl.py: FORCE

I'm not sure of this change. This makes it behave differently than the other tools. The issue with automatic fetch  when there's a version update is also there for other flashing tools (at least).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15396#pullrequestreview-527118748
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201110/f9e201c6/attachment.htm>