[riot-notifications] [RIOT-OS/RIOT] cpu/native: remove unused can_linux module (#15407)

Wouter Symons notifications at github.com
Tue Nov 10 16:50:20 CET 2020


@wosym commented on this pull request.



> @@ -20,7 +20,7 @@
  */
 
 #if !defined(__linux__)
-#error "MODULE can_linux is only available on Linux"
+#error "MODULE periph_can is only available on Linux"

I understand the purpose of this message (even though at first I also misinterpreted it), but for people unfamiliar to RIOT or unfamiliar to the RIOT can-system, this message is very ambiguous. It can be understood as "You can only use periph_can when running RIOT on Linux (i.e. native)", which is not the case. 
I would reword it to something along the lines of "Usage of periph_can on RIOT native requires libsocketcan. Currently this is only available on Linux". 

(I'm still not 100% convinced about my own proposition. There's still room for confusion. But I would go more or less in this direction to avoid users from misinterpreting what is supported and what is not.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15407#discussion_r520668255
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201110/e867f0ca/attachment.htm>


More information about the notifications mailing list