[riot-notifications] [RIOT-OS/RIOT] examples/gnrc_border_route: simplify ZEP setup on native (#14755)

Martine Lenders notifications at github.com
Wed Nov 11 12:31:11 CET 2020


@miri64 requested changes on this pull request.

> tests/gnrc_netif_ieee802154 needs to disable the HELLO packet, […]

I guess you meant "needs not to enable the HELLO packet", because as far as I can see this (and hope it) is not a default module,

> +#ifdef MODULE_SOCKET_ZEP_HELLO
+    /* dummy packet */
+    zep_v2_data_hdr_t hdr = {
+        .hdr.preamble = "EX",
+        .hdr.version  = 2,
+        .type = SOCKET_ZEP_V2_TYPE_HELLO,
+        .resv = "HELLO",
+    };
+
+    real_write(dev->sock_fd, &hdr, sizeof(hdr));
+#else
+    (void)dev;
+#endif

```suggestion
    if (IS_USED(MODULE_SOCKET_ZEP_HELLO)) {
        /* dummy packet */
        zep_v2_data_hdr_t hdr = {
            .hdr.preamble = "EX",
            .hdr.version  = 2,
            .type = SOCKET_ZEP_V2_TYPE_HELLO,
            .resv = "HELLO",
        };

        real_write(dev->sock_fd, &hdr, sizeof(hdr));
    }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14755#pullrequestreview-528088993
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201111/72ca340d/attachment.htm>


More information about the notifications mailing list