[riot-notifications] [RIOT-OS/RIOT] examples/gnrc_border_route: simplify ZEP setup on native (#14755)
notifications at github.com
Wed Nov 11 16:18:19 CET 2020
@miri64 commented on this pull request.
> + ifeq (,$(filter socket_zep,$(USEMODULE)))
+ USEMODULE += netdev_tap
> Mind you that this behavior of 'overwriting' the default netdev is already used by [nrf52](https://github.com/RIOT-OS/RIOT/blob/master/boards/common/nrf52/nrf52840/Makefile.dep) and [esp*](https://github.com/RIOT-OS/RIOT/blob/master/cpu/esp_common/Makefile.dep#L37), I thought it would be straightforward to do the same for `native`.
I know, but in this instance, for this specific PR, it seems making more fuzz then necessary. If you want, we can discuss this in a separate PR. I agree this should be more unified to other platforms, but as we already learned, this is affecting other applications than the one targeted by this PR, so we should rather discuss it in a different scope.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications