[riot-notifications] [RIOT-OS/RIOT] boards/saml21-xpro: add gpio_params.h (#15432)

Alexandre Abadie notifications at github.com
Wed Nov 11 17:56:47 CET 2020


@aabadie commented on this pull request.



> +#include "saul/periph.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief    GPIO pin configuration
+ */
+static const  saul_gpio_params_t saul_gpio_params[] =
+{
+    {
+        .name = "LED(orange)",
+        .pin = LED0_PIN,
+        .mode = GPIO_OUT,
+        .flags = SAUL_GPIO_INVERTED

Are you sure you don't need  `SAUL_GPIO_INIT_CLEAR` as well for both the LED and the button ? This is done like this on samr30 and samr34 xpro boards (also l21 based).

```suggestion
        .flags = SAUL_GPIO_INVERTED | SAUL_GPIO_INIT_CLEAR
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15432#pullrequestreview-528358047
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201111/ace0ce0e/attachment.htm>


More information about the notifications mailing list