[riot-notifications] [RIOT-OS/RIOT] examples/gnrc_border_route: simplify ZEP setup on native (#14755)

Martine Lenders notifications at github.com
Thu Nov 12 08:48:48 CET 2020


@miri64 commented on this pull request.



> @@ -69,7 +69,7 @@ endif
 LINKFLAGS += -ffunction-sections
 
 # set the tap interface for term/valgrind
-ifneq (,$(filter netdev_default,$(USEMODULE)))
+ifneq (,$(filter netdev_tap,$(USEMODULE)))

IIRC this won't work BTW, since `netdev_tap` might not be selected at this point yet.

> @@ -14,6 +16,7 @@ ifneq (,$(filter periph_can,$(FEATURES_USED)))
 endif
 
 ifneq (,$(filter socket_zep,$(USEMODULE)))
+  DEFAULT_MODULE += socket_zep_hello

Ermm... I meant that the opt-in mechanism should be documented in the README of `zep_dispatch` (and / or the `gnrc_border_router` example), not that the opt-out mechanism should be kept and stay in the documentation...

> +  ifeq (,$(filter socket_zep,$(USEMODULE)))
+    USEMODULE += netdev_tap
+  endif

(with the changes of #15430 removed first of course)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14755#pullrequestreview-528817822
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201111/d5d7ccca/attachment.htm>


More information about the notifications mailing list