[riot-notifications] [RIOT-OS/RIOT] sys/shell: new module shell_lock (#13082)

Hendrik van Essen notifications at github.com
Thu Nov 12 19:32:10 CET 2020


Thank you very much for your detailed reasoning. I can see now that it might be tricky to make it instantly clear for people who are expecting a safe solution for the problem of access control that this module is (at the moment) not the right/safe way to go for a real world application.
Generally I don't have experience with merging code, which was meant for demo purposes only, in to RIOTs repository. Anything else I was working on before is usable in production, so I don't have a feeling for the consensus of the community at this point. It would be interesting to hear some opinions about that.
I still believe that for demo purposes this is a nice thing to add though, because especially with the upcoming module `stdio_nimble` you want do have some more control about the access to the shell. But I can totally understand the fact that the features RIOT provides within the official repository should have a certain level of maturity. I'm not against renaming this module to `shell_lock_demo` or something similar for example if it helps to clarify the intended use case of demo projects.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13082#issuecomment-726259587
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201112/775562f5/attachment.htm>


More information about the notifications mailing list