[riot-notifications] [RIOT-OS/RIOT] riotboot/flashwrite: support non-uniform flash page sizes (#15423)

Alexandre Abadie notifications at github.com
Fri Nov 13 15:56:53 CET 2020


@aabadie commented on this pull request.



>          size_t flashwrite_buffer_pos = state->offset % RIOTBOOT_FLASHPAGE_BUFFER_SIZE;
         size_t flashpage_avail = RIOTBOOT_FLASHPAGE_BUFFER_SIZE - flashwrite_buffer_pos;
 
         size_t to_copy = min(flashpage_avail, len);
 
-        if (CONFIG_RIOTBOOT_FLASHWRITE_RAW && flashpage_pos == 0) {
+        void * target_addr = (uint8_t*)riotboot_slot_get_hdr(state->target_slot) + state->offset;

```suggestion
        void *target_addr = (uint8_t *)riotboot_slot_get_hdr(state->target_slot) + state->offset;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15423#pullrequestreview-530129783
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201113/e055a87b/attachment.htm>


More information about the notifications mailing list