[riot-notifications] [RIOT-OS/RIOT] tests/unittests: split out atomic_utils unittests (#15438)

Alexandre Abadie notifications at github.com
Fri Nov 13 08:40:33 CET 2020

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

#14331 broke the CI because unittests don't fit anymore on arm7 based boards (msba2 and mcb2388), this PR move the sys atomic_utils from the unittests to their own test application.

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

- A green Murdock
- Check that `tests/sys_atomic_utils_unittests` are working:


$ BUILD_IN_DOCKER=1 make -C tests/sys_atomic_utils_unittests all test --no-print-directory 
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/work/riot/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'        -w '/data/riotbuild/riotbase/tests/sys_atomic_utils_unittests/' 'riot/riotbuild:latest' make     all
Building application "tests_sys_atomic_utils_unittests" for "native" with MCU "native".

"make" -C /data/riotbuild/riotbase/boards/native
"make" -C /data/riotbuild/riotbase/boards/native/drivers
"make" -C /data/riotbuild/riotbase/core
"make" -C /data/riotbuild/riotbase/cpu/native
"make" -C /data/riotbuild/riotbase/cpu/native/periph
"make" -C /data/riotbuild/riotbase/cpu/native/stdio_native
"make" -C /data/riotbuild/riotbase/drivers
"make" -C /data/riotbuild/riotbase/drivers/periph_common
"make" -C /data/riotbuild/riotbase/sys
"make" -C /data/riotbuild/riotbase/sys/auto_init
"make" -C /data/riotbuild/riotbase/sys/embunit
"make" -C /data/riotbuild/riotbase/sys/luid
"make" -C /data/riotbuild/riotbase/sys/random
"make" -C /data/riotbuild/riotbase/sys/random/tinymt32
"make" -C /data/riotbuild/riotbase/sys/test_utils/interactive_sync
   text	   data	    bss	    dec	    hex	filename
  52602	    728	  47804	 101134	  18b0e	/data/riotbuild/riotbase/tests/sys_atomic_utils_unittests/bin/native/tests_sys_atomic_utils_unittests.elf
RIOT native interrupts/signals initialized.
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
main(): This is RIOT! (Version: 2021.01-devel-832-gfc8b1-pr/tests/sys_atomic_unittest)
OK (7 tests)



Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references

Restore the CI that was broken in #14331

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * tests/sys_atomic_utils_unittest: add sys atomic utils unittests
  * tests/unittests: remove atomic-utils from unittests

-- File Changes --

    A tests/sys_atomic_utils_unittests/Makefile (7)
    R tests/sys_atomic_utils_unittests/main.c (8)
    A tests/sys_atomic_utils_unittests/tests/01-run.py (15)
    D tests/unittests/tests-atomic_utils/Makefile (1)
    D tests/unittests/tests-atomic_utils/Makefile.include (2)
    D tests/unittests/tests-atomic_utils/tests-atomic_utils.h (38)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201113/0c9cfffb/attachment-0001.htm>

More information about the notifications mailing list