[riot-notifications] [RIOT-OS/RIOT] .murdock: run Kconfig compilation first when needed (#15419)

[Alexandre Abadie]

@aabadie commented on this pull request.



> @@ -240,37 +240,46 @@ compile() {
     [ $# -ne 2 ] && error "$0: compile: invalid parameters (expected \$appdir \$board:\$toolchain)"
     [ ! -d "$appdir" ] && error "$0: compile: error: application directory \"$appdir\" doesn't exist"
 
-    # compile
+    # We compile a first time with Kconfig based dependency
+    # resolution for regression purposes. $TEST_KCONFIG contains a
+    # list of board-application tuples that are currently modeled to
+    # run with Kconfig
+
+    # we can't use '-' in variable names
+    _board=$(echo ${board} | tr '-' '_')

I don't understand why this is needed. I don't see where the content of ${board} is used as variable name.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15419#pullrequestreview-530176821
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201113/9cb5fe51/attachment.htm>