[riot-notifications] [RIOT-OS/RIOT] drivers: add gp2y10xx dust sensor (#15445)

benpicco notifications at github.com
Mon Nov 16 10:52:16 CET 2020


@benpicco commented on this pull request.



> +        _iled_on(dev);
+        xtimer_usleep(ILED_PULSE_WAIT_US);

```suggestion
        xtimer_usleep(ILED_PULSE_WAIT_US);
        _iled_on(dev);
```

The way I understand the current ADC API, the samping should only start with `adc_sample()` - so you could turn off the LED while you wait for the next period.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15445#pullrequestreview-531163882
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201116/b518ad00/attachment.htm>


More information about the notifications mailing list