[riot-notifications] [RIOT-OS/RIOT] stm32f{2, 4, 7}: Initial flashpage support (#15420)

Francisco notifications at github.com
Mon Nov 16 13:44:24 CET 2020


@fjmolinas commented on this pull request.



>  #define FLASHPAGE_NUMOF                 (STM32_FLASHSIZE / FLASHPAGE_SIZE)
+#endif
+
+#if defined(CPU_FAM_STM32F2) || defined(CPU_FAM_STM32F4) || \
+    defined(CPU_FAM_STM32F7)
+#define PERIPH_FLASHPAGE_CUSTOM_PAGESIZES
+
+/* DB1M splits the 1MB into two banks, 2MB devices are always split on stm32f4 */
+#if (defined(FLASH_OPTCR_DB1M) && (STM32_FLASHSIZE >= (1024 * 1024)))
+#define FLASHPAGE_DUAL_BANK             (1)

It would be nice to have a better definition of this one. There are some assumptions here that would be better be made explicit like the fact that `DB1M` is not changed by the user, and that the current configuration is the default one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15420#pullrequestreview-531285605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201116/e8534cf6/attachment.htm>


More information about the notifications mailing list