[riot-notifications] [RIOT-OS/RIOT] Renode improvements (#15427)

[Bas Stottelaar]

@basilfx commented on this pull request.

A few comments here and there. 

> @@ -730,7 +730,7 @@ debug-server:
 	$(call check_cmd,$(DEBUGSERVER),Debug server program)
 	$(DEBUGSERVER) $(DEBUGSERVER_FLAGS)
 
-emulate:
+emulate: all

Out of curiosity: why is this needed?

> @@ -1,30 +1,35 @@
-mach create
-using sysbus
-machine LoadPlatformDescription @platforms/cpus/cc2538.repl
+:name: CC2538
+:description: This script runs Contiki-NG hello-world example on CC2538.
+
+$name?="CC2538"
+$bin?=@https://dl.antmicro.com/projects/renode/cc2538-contiki_hello_world.elf-s_242120-08fc83d11f790ccc1aa46abfdfc9c2e1a94baed2

Check my version at https://github.com/basilfx/RIOT/tree/feature/renode.

> @@ -10,5 +10,8 @@ FEATURES_PROVIDED += periph_spi
 FEATURES_PROVIDED += periph_timer
 FEATURES_PROVIDED += periph_uart periph_uart_modecfg
 
+# Various other features (if any)
+FEATURES_PROVIDED += emulator_renode

I see this at multiple places, but it doesn't seem to be used, right?

>  # Default Renode command
-: ${RENODE:=renode}
+if [ ! -f "${RENODE}" ]; then

Isn't `${RENODE:=renode}` doing the same?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15427#pullrequestreview-531844351
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201116/0221ed07/attachment.htm>