[riot-notifications] [RIOT-OS/RIOT] replace netif_addr_to/from_str() with l2util_addr_to/from_str() (#15443)

Martine Lenders notifications at github.com
Tue Nov 17 12:27:27 CET 2020


@miri64 commented on this pull request.



> @@ -476,6 +476,10 @@ ifneq (,$(filter ieee802154_submac,$(USEMODULE)))
   USEMODULE += xtimer
 endif
 
+ifneq (,$(filter l2util,$(USEMODULE)))
+  USEMODULE += fmt

Should we maybe make this dependency optional (as in, only use `fmt_byte_hex()` if `fmt` is compiled in, otherwise use a simple local function). It seems weird to include this just for creating strings from addresses, which might not be used with l2util all the time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15443#pullrequestreview-532267472
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201117/4b51da98/attachment.htm>


More information about the notifications mailing list