[riot-notifications] [RIOT-OS/RIOT] sys/atomic_utils: Use volatile qualifier (#15465)

Marian Buschsieweke notifications at github.com
Wed Nov 18 13:47:48 CET 2020


> The "API change" and "minor" labels seem to be kind of conflicting. But this API change is fully backward compatible, so I'd say this makes sense here. For that reason (and because the API was not yet part of any release), I think a single ACK should be sufficient here.

OK, this didn't work out as smoothly as I hoped. The unit tests have `typedef`ed the signature of the atomic utils and compilation broke for that reason. Normal uses of the atomic utils (just calling a function) should not be affected by this, as the pointers can be implicitly converted to `volatile` pointers of the same type.

I also split out the `volatile_utils.h` header (as @kaspar030 already suggested in the original PR) to deduplicate code between the unit tests. I should have listened to @kaspar030 in the first place :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15465#issuecomment-729654924
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201118/26ba3c53/attachment.htm>


More information about the notifications mailing list