[riot-notifications] [RIOT-OS/RIOT] cpu/efm32: add coretemp driver (#15461)

benpicco notifications at github.com
Wed Nov 18 15:51:01 CET 2020


@benpicco commented on this pull request.



> @@ -0,0 +1,17 @@
+BOARD ?= sltb001a
+include ../Makefile.tests_common
+
+BOARD_WHITELIST := ikea-tradfri \

I mean we could have

```C
#ifndef CORETEMP_ADC
#define CORETEMP_ADC        ADC_LINE(0)
#endif 
```

so we don't have to re-define this for every board.

> Too bad this got merged so fast without a proper analysis of the situation IMHO.

The API is not set in stone yet, we can change the function names easiely as a follow up.
nRF5x also has this feature `saul_nrf_temperature` so a common API would make sense.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15461#discussion_r526146772
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201118/959bba8a/attachment.htm>


More information about the notifications mailing list